-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort update #34
base: master
Are you sure you want to change the base?
Sort update #34
Conversation
New package added for sorting json based on a param
First pass of UI design for sorting songs. Added semi-colons where needed
Add eslint rule for semicolons
Quick ternary update before heading back to work.
A couple of observations:
Also, implementing some arrows next to the sort criteria might make the UI look a little better. See sorting in the mod list and ModListView.js for examples. This is merely a suggestion. If you think that would be awkward, then you can leave it as it is. BeatDrop/src/components/ModsListView.js Lines 62 to 67 in 760853f
|
@@ -54,6 +54,11 @@ | |||
margin-left: 5px; | |||
opacity: 0.5; | |||
} | |||
.bpm { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3
@brandonhenry Any chance you could continue on this? I think many are interested in sorting and filtering, but it seems like your request has stalled. Maybe re-doing the pull request from a fresh repo would avoid the conflicts? |
This has stalled because there is little that can be done. True sorting/filtering on BeatSaver song cannot be done locally, it must be done by the server. Unless BeatSaver implements these functions, there is nothing to be done unfortunately. |
Used current structure (sortBar) to add sorting by song name, author name, BPM, and difficulty. This is only supported for local songs as such sorting by other factors such as PP, upvotes, etc are not included. Can also sort ascending/descending.