Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning timeout update #38

Open
wants to merge 19 commits into
base: alpha
Choose a base branch
from
Open

Warning timeout update #38

wants to merge 19 commits into from

Conversation

brandonhenry
Copy link
Collaborator

No description provided.

@brandonhenry brandonhenry self-assigned this Jun 9, 2019
transition: 0s;
}
}

#resize-button, #minimize-button {
&:hover {
background: silver;
background: rgba(128, 128, 128, 0.3);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(128, 128, 128, 0.3) should only be used in variable declarations; they should be referred to via variable everywhere else.

@@ -125,14 +112,14 @@

#close-button {
&:hover {
background: #e0021f;
background: #ff1938;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like #ff1938 should only be used in variable declarations; they should be referred to via variable everywhere else.

@@ -89,21 +88,9 @@
}

&.theme-dark {
background: #252525;
background: rgba(0, 0, 0, 0.6);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color literals like rgba(0, 0, 0, 0.6) should only be used in variable declarations; they should be referred to via variable everywhere else.

background: url(../assets/update.png);
background-repeat: no-repeat;
transition: .5s;
}
}

h5.scanning-text {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid qualifying class selectors with an element.

text-align: center;

&::before {
&:first-child::before {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule set contains (12/10) properties

@@ -49,6 +49,11 @@
white-space: nowrap;
text-overflow: ellipsis;
}
.upload-date {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

margin-bottom: 5px;
}

#dl-location, #theme-image-path {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using id selectors
Each selector in a comma sequence should be on its own single line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants