[Test] Add backticks to column identifiers to fix queries for column names with .
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ddesilva12
commented
Mar 6, 2024
| @@ -33,7 +33,7 @@ check_flink_version_supported $flink_minor_version | |||
| flink_version="$(get_flink_version $flink_minor_version)" | |||
| kafka_connector_version="$(get_kafka_connector_version $flink_minor_version)" | |||
|
|
|||
| ${MVN_CMD} clean package -DskipTests \ | |||
| ${MVN_CMD} clean package -DskipTests -Drat.skip=true \ | |||
There was a problem hiding this comment.
disable rat to get build to work
| @@ -376,7 +376,7 @@ limitations under the License. | |||
| <execution> | |||
| <phase>package</phase> | |||
| <goals> | |||
| <goal>jar</goal> | |||
| <goal>test-jar</goal> | |||
| for (int index : curProjectedFields) { | ||
| String columnName = flinkSchema.getFieldName(index).get(); | ||
| String columnName = "`" + flinkSchema.getFieldName(index).get() + "`"; |
| @@ -85,7 +85,7 @@ public String visit(ValueLiteralExpression valueLiteral) { | |||
|
|
|||
| @Override | |||
| public String visit(FieldReferenceExpression fieldReference) { | |||
| return fieldReference.getName(); | |||
| return "`" + fieldReference.getName() + "`"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
Not production ready yet - need to make this solution a little bit cleaner and ensure no regressions occur