Skip to content

Commit

Permalink
fix: missing dependencies in the framework package (medusajs#11049)
Browse files Browse the repository at this point in the history
In the framework package we are directly importing many uninstalled dependencies. The issue does not occur for transitive dependencies. However, the `glob` package is not a transitive dependency of any production dependency and hence it fails.

Fixes: medusajs#11044
Fixes: FRMW-2877
  • Loading branch information
thetutlage authored Jan 20, 2025
1 parent e448734 commit 171088b
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 15 deletions.
5 changes: 5 additions & 0 deletions .changeset/witty-mugs-confess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/framework": patch
---

fix: missing dependencies in the framework package
3 changes: 3 additions & 0 deletions packages/core/framework/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,15 @@
"@medusajs/workflows-sdk": "^2.3.0",
"@opentelemetry/api": "^1.9.0",
"@types/express": "^4.17.17",
"compression": "1.7.4",
"connect-redis": "5.2.0",
"cookie-parser": "^1.4.6",
"cors": "^2.8.5",
"express": "^4.21.0",
"express-session": "^1.17.3",
"glob": "7.2.3",
"jsonwebtoken": "^9.0.2",
"lodash": "4.17.21",
"morgan": "^1.9.1",
"tsconfig-paths": "^4.2.0",
"zod": "3.22.4"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/framework/src/zod/zod-helpers.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MedusaError } from "@medusajs/framework/utils"
import { MedusaError } from "../utils"
import {
z,
ZodError,
Expand Down
31 changes: 17 additions & 14 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5759,14 +5759,17 @@ __metadata:
"@types/express": ^4.17.17
"@types/jsonwebtoken": ^8.5.9
awilix: ^8.0.1
compression: 1.7.4
connect-redis: 5.2.0
cookie-parser: ^1.4.6
cors: ^2.8.5
express: ^4.21.0
express-session: ^1.17.3
glob: 7.2.3
ioredis: ^5.4.1
jest: ^29.7.0
jsonwebtoken: ^9.0.2
lodash: 4.17.21
morgan: ^1.9.1
pg: ^8.13.0
rimraf: ^3.0.2
Expand Down Expand Up @@ -21064,6 +21067,20 @@ __metadata:
languageName: node
linkType: hard

"glob@npm:7.2.3, glob@npm:^7.0.5, glob@npm:^7.1.1, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.6, glob@npm:^7.2.0, glob@npm:~7.2.0":
version: 7.2.3
resolution: "glob@npm:7.2.3"
dependencies:
fs.realpath: ^1.0.0
inflight: ^1.0.4
inherits: 2
minimatch: ^3.1.1
once: ^1.3.0
path-is-absolute: ^1.0.0
checksum: 65676153e2b0c9095100fe7f25a778bf45608eeb32c6048cf307f579649bcc30353277b3b898a3792602c65764e5baa4f643714dfbdfd64ea271d210c7a425fe
languageName: node
linkType: hard

"glob@npm:^10.0.0, glob@npm:^10.2.2, glob@npm:^10.3.10, glob@npm:^10.3.7":
version: 10.3.12
resolution: "glob@npm:10.3.12"
Expand Down Expand Up @@ -21108,20 +21125,6 @@ __metadata:
languageName: node
linkType: hard

"glob@npm:^7.0.5, glob@npm:^7.1.1, glob@npm:^7.1.3, glob@npm:^7.1.4, glob@npm:^7.1.6, glob@npm:^7.2.0, glob@npm:~7.2.0":
version: 7.2.3
resolution: "glob@npm:7.2.3"
dependencies:
fs.realpath: ^1.0.0
inflight: ^1.0.4
inherits: 2
minimatch: ^3.1.1
once: ^1.3.0
path-is-absolute: ^1.0.0
checksum: 65676153e2b0c9095100fe7f25a778bf45608eeb32c6048cf307f579649bcc30353277b3b898a3792602c65764e5baa4f643714dfbdfd64ea271d210c7a425fe
languageName: node
linkType: hard

"glob@npm:^8.0.3, glob@npm:^8.1.0":
version: 8.1.0
resolution: "glob@npm:8.1.0"
Expand Down

0 comments on commit 171088b

Please sign in to comment.