Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from medusajs:develop #2

Merged
merged 0 commits into from
Dec 17, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 17, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhance the Medusa project with a new workflow for listing shipping options with pricing, and refactor the Stripe integration in the Next.js Starter to support multiple payment methods using the Stripe Payment Element. Update package versions and documentation, and add tests for the new features.

New Features:

  • Introduce a new workflow for listing shipping options with pricing for a cart, which calculates prices for both flat rate and calculated shipping options.
  • Add support for handling external payment callbacks in the Next.js Starter, allowing users to complete payments through external providers like PayPal.

Enhancements:

  • Refactor the Stripe payment integration in the Next.js Starter to use the Stripe Payment Element, supporting multiple payment methods.
  • Improve the handling of pricing context in cart workflows to ensure accurate pricing calculations.

Build:

  • Update package versions across multiple modules to 2.1.2, ensuring consistency and compatibility.

Documentation:

  • Add a new guide for customizing the Stripe integration in the Next.js Starter, detailing how to use the Stripe Payment Element for multiple payment methods.
  • Update documentation to clarify the use of the 'fields' query parameter in API routes, noting that certain routes do not allow expanding custom relations.

Tests:

  • Add integration tests for the new shipping option calculation workflow, ensuring it correctly handles both flat rate and calculated options.

@pull pull bot added the ⤵️ pull label Dec 17, 2024
Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This pull request introduces several significant changes across the Medusa codebase, primarily focusing on cart workflows, pricing context handling, and various module improvements. The changes include updates to payment processing, shipping calculations, and several bug fixes.

Sequence diagram for addToCartWorkflow

sequenceDiagram
    participant User
    participant CartService
    participant WorkflowManager
    User->>CartService: Add item to cart
    CartService->>WorkflowManager: run addToCartWorkflow
    WorkflowManager->>CartService: validateCartStep
    WorkflowManager->>CartService: useQueryGraphStep to get cart
    WorkflowManager->>CartService: transform to get variantIds
    WorkflowManager->>CartService: useRemoteQueryStep to fetch variants
    WorkflowManager->>CartService: prepareLineItemData
    WorkflowManager->>CartService: confirmVariantInventoryWorkflow
    WorkflowManager->>CartService: createLineItemsStep
    WorkflowManager->>CartService: updateLineItemsStep
    WorkflowManager->>CartService: refreshCartItemsWorkflow
    WorkflowManager->>CartService: emitEventStep
    CartService->>User: Return updated cart
Loading

Sequence diagram for calculateShippingOptionsPricesWorkflow

sequenceDiagram
    participant CartService
    participant WorkflowManager
    CartService->>WorkflowManager: run calculateShippingOptionsPricesWorkflow
    WorkflowManager->>CartService: useQueryGraphStep for shippingOptionsQuery
    WorkflowManager->>CartService: useQueryGraphStep for cartQuery
    WorkflowManager->>CartService: transform to get fulfillmentSetId
    WorkflowManager->>CartService: useQueryGraphStep for locationFulfillmentSetQuery
    WorkflowManager->>CartService: transform to get locationIds
    WorkflowManager->>CartService: useQueryGraphStep for locationQuery
    WorkflowManager->>CartService: transform to prepare data
    WorkflowManager->>CartService: Return calculated shipping options prices
Loading

Class diagram for FulfillmentModuleService modifications

classDiagram
    class FulfillmentModuleService {
        + deleteFulfillment(string id, Context sharedContext)
    }
    class Context {
        <<imported>>
    }
Loading

File-Level Changes

Change Details Files
Enhanced cart workflows to handle pricing context more accurately
  • Updated cart fields to include pricing context information
  • Modified payment session handling in cart workflows
  • Improved shipping option price calculations
  • Added support for calculated shipping options
packages/core/core-flows/src/cart/workflows/add-to-cart.ts
packages/core/core-flows/src/cart/workflows/update-line-item-in-cart.ts
packages/core/core-flows/src/cart/utils/fields.ts
packages/core/core-flows/src/cart/workflows/list-shipping-options-for-cart-with-pricing.ts
Improved pricing module to handle customer groups and pricing rules
  • Updated pricing context to support customer groups
  • Modified price list rules to use new customer group format
  • Enhanced price calculation logic
packages/modules/pricing/src/repositories/pricing.ts
packages/core/types/src/pricing/common/pricing-context.ts
packages/modules/pricing/src/migrations/Migration20241212190401.ts
Added support for float data type in cart tax rates
  • Changed tax rate columns to use float type
  • Added migration for tax rate column type change
packages/modules/cart/src/models/line-item-tax-line.ts
packages/modules/cart/src/models/shipping-method-tax-line.ts
packages/modules/cart/src/migrations/Migration20241216183049.ts
Enhanced Next.js starter with improved Stripe integration
  • Added support for multiple payment methods through Stripe Payment Element
  • Improved payment handling and confirmation flow
  • Added documentation for customizing Stripe integration
www/apps/resources/app/nextjs-starter/guides/customize-stripe/page.mdx
www/apps/resources/sidebar.mjs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Dec 17, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pull pull bot merged commit ee62083 into Stars1233:develop Dec 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants