[pull] develop from medusajs:develop #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
**What** Keep the autocompletion for the fields API in Query APIs while being more flexible in order to prevent limitation from our depth limit but also to be more flexible when assigning string[] coming from the API for example.
Replace usage of `useQueryStep` with `useGraphQueryStep` and remove `useQueryStep`, as it's not exported by the package and seems to be a duplicate of `useGraphQueryStep`
* fix: cart data passed to context, from location in validation * refactor: extract common fields to a const
Reviewer's Guide by SourceryThis PR primarily focuses on improving the shipping options calculation workflow and query handling in the Medusa core. The changes include refactoring field definitions, updating query step usage, and enhancing type definitions for remote queries. Class diagram for updated cart field utilitiesclassDiagram
class CartFields {
+cartFieldsForRefreshSteps: string[]
+cartFieldsForCalculateShippingOptionsPrices: string[]
}
note for CartFields "Updated to include new fields for calculating shipping options prices"
Class diagram for updated query step usageclassDiagram
class QuerySteps {
-useQueryStep
+useQueryGraphStep
}
note for QuerySteps "Replaced useQueryStep with useQueryGraphStep in workflows"
Class diagram for RemoteQueryObjectConfig typeclassDiagram
class RemoteQueryObjectConfig {
+TEntry: string
+RemoteQueryEntryPoints: Object
+ObjectToRemoteQueryFields: Object[] | string[]
}
note for RemoteQueryObjectConfig "Enhanced type definitions to support string arrays"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Refactor the core workflows to replace useQueryStep with useQueryGraphStep for better query management and update type definitions to enhance IntelliSense while providing more flexibility.
Enhancements:
Chores: