Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from medusajs:develop #9

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 20, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Bug Fixes:

  • Fixed a bug where inventory was reserved from the wrong stock location when a product belonged to multiple sales channels.

…SC (#10661)

* fix: add stock location for reservations only if related to correct SC

* fix: update spec

* fix: wrong SC id get in OE flow

* fix: ensure test case has multiple SC and SLs
@pull pull bot added the ⤵️ pull label Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the cart and order editing workflows to correctly handle inventory reservations when multiple sales channels are used. It also adds tests to verify the correct behavior.

Sequence diagram for inventory confirmation with sales channel check

sequenceDiagram
    participant Cart
    participant InventoryConfirmation
    participant StockLocation
    participant SalesChannel

    Cart->>InventoryConfirmation: prepareConfirmInventoryInput()
    InventoryConfirmation->>SalesChannel: Check sales_channel.id
    alt sales_channel.id matches salesChannelId
        InventoryConfirmation->>StockLocation: Add stock_location.id
        StockLocation-->>InventoryConfirmation: Return location ID
    else No match
        InventoryConfirmation-->>Cart: Skip stock location
    end
    InventoryConfirmation-->>Cart: Return prepared inventory input
Loading

Class diagram for order edit workflow changes

classDiagram
    class OrderEdit {
        +confirmOrderEditRequest()
    }
    class InventoryConfirmation {
        +prepareConfirmInventoryInput(data)
        -validateSalesChannel()
    }
    class OrderItem {
        +sales_channel_id
        +variants
        +items
    }
    OrderEdit --> InventoryConfirmation: uses
    OrderEdit --> OrderItem: manages
    note for InventoryConfirmation "Updated to check sales channel ID match"
    note for OrderItem "Changed to use direct sales_channel_id"
Loading

File-Level Changes

Change Details Files
Handle inventory reservations for multiple sales channels
  • Modified the prepareConfirmInventoryInput function to only consider stock locations associated with the correct sales channel.
  • Updated the confirmOrderEditRequestWorkflow to use the correct sales channel ID when reserving inventory.
  • Ensured that the completeCart workflow correctly handles inventory reservations for multiple sales channels by passing the correct sales channel ID
packages/core/core-flows/src/cart/utils/prepare-confirm-inventory-input.ts
packages/core/core-flows/src/order/workflows/order-edit/confirm-order-edit-request.ts
packages/core/core-flows/src/cart/workflows/complete-cart.ts
Added integration tests for multiple sales channels
  • Added tests to verify that the correct stock location is selected for reservations when a product is added to multiple sales channels.
  • Created test cases to cover scenarios with multiple sales channels and stock locations.
  • Added tests to ensure that the cart creation workflow correctly handles the sales channel ID.
  • Updated existing tests to account for multiple sales channels and stock locations
integration-tests/modules/__tests__/cart/store/carts.spec.ts
integration-tests/modules/__tests__/cart/store/cart.workflows.spec.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pull pull bot merged commit fc321e9 into Stars1233:develop Dec 20, 2024
Copy link

coderabbitai bot commented Dec 20, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant