-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ktutil and a helper script to our images #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment and if you could confirm the following:
This will trigger for everyone and every notebook?
This script command will be available on every notebook type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random not a specific place to write comments:
- What if the user enters the wrong password? Does it update?
- What if they use the keytab with a wrong password, what happens
- is one keytab valid for all notebooks, (I think so) if so, does the file appear/is visible without the user needing to do the command.
- If not, does it mean only one is valid at a time
- I don't think this is related to your ticket but any chance some of this can be cleaned up :
- What if the notebook is not persistent?
|
||
# add script for kerberos keytab creation | ||
COPY ktutil-keytab.sh /usr/local/bin/ktutil-keytab | ||
RUN chmod +x /usr/local/bin/ktutil-keytab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a prompt/instructions for the user to know to run this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a ticket to define those instructions in the docs to let users know what to do
https://jirab.statcan.ca/browse/BTIS-686
|
Description
for https://jirab.statcan.ca/browse/BTIS-700
Tests / Quality Checks
Can be tested by running "ktutil-keytab" in a terminal in a running notebook
Are there breaking changes?
Ask yourself the next question;
If no, then carry on. If yes, there is a breaking change and we want to maintain the previous image do the following
Automated Testing/build and deployment
auto-deploy
tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?JupyterLab extensions
jupyter labextension list
from inside the notebook)?VS Code tests
Code review
auto-deploy
tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselvesk8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b
)?