Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accordion docs and fixed code preview scroll bar issue. #20

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Update accordion docs and fixed code preview scroll bar issue. #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54939a
Updated: set Accordion component item type default value.
moshiur01 Oct 28, 2024
edd5dfb
Updated: Accordion docs.
moshiur01 Oct 28, 2024
feb013c
Fixed: Code Highlight scroll bar not showing issue.
moshiur01 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/content/CodeHighlightWithPreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const handleCopy = (code: object) => {
</div>
<div
v-if="active !== 0"
id="linkPage"
id="codeHighlight"
class="max-h-[420px] overflow-y-auto bg-[#111b27] p-8 text-body-4">
<Shiki
lang="ts"
Expand Down
12 changes: 6 additions & 6 deletions components/content/docs/components/accordion/AccordionCode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const accordionItems = [
</script>

<template>
<Accordion class="w-full" type="single" collapsible>
<Accordion class="w-full" collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down Expand Up @@ -78,7 +78,7 @@ const accordionItems = [

<template>
<Accordion
type="single"

class="space-y-4"
collapsible
:default-value="defaultValue">
Expand Down Expand Up @@ -135,7 +135,7 @@ const accordionItems = [
</script>

<template>
<Accordion type="single" flush collapsible>
<Accordion flush collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down Expand Up @@ -170,7 +170,7 @@ import {
</script>

<template>
<Accordion type="single" class="w-full space-y-4" collapsible>
<Accordion class="w-full space-y-4" collapsible>
<AccordionPanel value="item-1">
<AccordionContainer>
<AccordionTitle class="first-letter:text-primary-500">
Expand Down Expand Up @@ -265,7 +265,7 @@ const accordionItems = [
</script>

<template>
<Accordion type="single" class="w-full" collapsible>
<Accordion class="w-full" collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down Expand Up @@ -312,7 +312,7 @@ const accordionItems = [
</script>

<template>
<Accordion disabled type="single" class="w-full" collapsible>
<Accordion disabled class="w-full" collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down
12 changes: 10 additions & 2 deletions components/content/docs/components/accordion/accordionApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,22 @@ export const accordionApiData = [
propsDescription: "Keep selected panel always open.",
},
{
id: 3,
id: 2,
propsName: "flush",
propsType: "boolean",
propsDescription: "Accordion without outer border and and background color",
default: "false",
},
{
id: 7,
id: 3,
propsName: "type",
propsType: ["single", "multiple"],
propsDescription:
"Determines whether a single or multiple items can be pressed at a time.",
default: "single",
},
{
id: 4,
propsName: "disabled",
propsType: "boolean",
propsDescription: "Disable interaction with the accordion.",
Expand Down
6 changes: 1 addition & 5 deletions components/content/docs/components/accordion/variant/AccordionOpenFirstPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,7 @@ const accordionItems = [

<template>
<CodeHighlightWithPreview :code="AccordionOpenFirstPanelCode">
<Accordion
type="single"
class="space-y-4"
collapsible
:default-value="defaultValue">
<Accordion class="space-y-4" collapsible :default-value="defaultValue">
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down
2 changes: 1 addition & 1 deletion components/content/docs/components/accordion/variant/AccordionWithCustomIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { AccordionWithCustomIconCode } from "../AccordionCode";

<template>
<CodeHighlightWithPreview :code="AccordionWithCustomIconCode">
<Accordion type="single" class="w-full space-y-4" collapsible>
<Accordion class="w-full space-y-4" collapsible>
<AccordionPanel value="item-1">
<AccordionContainer>
<AccordionTitle class="first-letter:text-primary-500">
Expand Down
2 changes: 1 addition & 1 deletion components/content/docs/components/accordion/variant/AccordionWithoutIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const accordionItems = [

<template>
<CodeHighlightWithPreview :code="AccordionWithoutIconCode">
<Accordion type="single" class="w-full" collapsible>
<Accordion class="w-full" collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down
2 changes: 1 addition & 1 deletion components/content/docs/components/accordion/variant/DefaultAccordion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { DefaultAccordionCode } from "../AccordionCode";

<template>
<CodeHighlightWithPreview :code="DefaultAccordionCode">
<Accordion type="single" class="w-full" collapsible>
<Accordion class="w-full" collapsible>
<AccordionPanel value="item-1">
<AccordionContainer>
<AccordionTitle class="first-letter:text-primary-500">
Expand Down
2 changes: 1 addition & 1 deletion components/content/docs/components/accordion/variant/DisabledAccordion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const accordionItems = [

<template>
<CodeHighlightWithPreview :code="AccordionDisabledCode">
<Accordion disabled type="single" class="w-full space-y-4" collapsible>
<Accordion disabled class="w-full space-y-4" collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down
2 changes: 1 addition & 1 deletion components/content/docs/components/accordion/variant/FlushAccordion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const accordionItems = [

<template>
<CodeHighlightWithPreview :code="flushAccordionCode">
<Accordion type="single" flush collapsible>
<Accordion flush collapsible>
<AccordionPanel
v-for="item in accordionItems"
:key="item.value"
Expand Down
2 changes: 1 addition & 1 deletion content/docs/components/accordion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Use the `default-value` property to set the first accordion panel to be open by

## Flush Accordion

Control the initial state of accordion panels with the `flush` property. As we use Redix vue for the accordion you have to give `type` prop value when using accordion.
Control the initial state of accordion panels with the `flush` property.

::FlushAccordion

Expand Down
7 changes: 6 additions & 1 deletion src/components/Accordion/Accordion.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ export interface AccordionFlushProps {
flush?: boolean;
}

const props = defineProps<AccordionRootProps & AccordionFlushProps>();
const props = withDefaults(
defineProps<AccordionRootProps & AccordionFlushProps>(),
{
type: "single",
},
);

const emits = defineEmits<AccordionRootEmits>();

Expand Down
11 changes: 11 additions & 0 deletions styles/docs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,17 @@
background-color: #e9eff6 !important;
}

#codeHighlight::-webkit-scrollbar {
width: 4px !important;
}
#codeHighlight::-webkit-scrollbar-track {
background-color: #7c8da0 !important;
}
#codeHighlight::-webkit-scrollbar-thumb {
border-radius: 10px;
background-color: #e9eff6 !important;
}

#radix-vue-dialog-content-1::-webkit-scrollbar {
display: none;
width: 4px !important;
Expand Down