Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve plugin order when reinstalling/updating #530

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

jurassicplayer
Copy link
Contributor

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: #513

This change preserves the plugin order if the plugin is already installed and assumes that when calling _install on an already installed plugin, either reinstall/update was used and the entry should in theory still be there after install (this assumption can fail if the install fails). This should preserve the order across full reboots and should be tested with full reboots after plugin changes (re-installs and updates, but no harm in checking plugin installs and deletions as well).

@TrainDoctor TrainDoctor added the enhancement New feature or request label Aug 25, 2023
@TrainDoctor TrainDoctor requested review from a team August 25, 2023 17:33
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine under SteamOS Stable/Beta/Preview

@TrainDoctor TrainDoctor merged commit 22d5795 into SteamDeckHomebrew:main Aug 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants