-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plugin.uninstall callback support #555
Conversation
…or a first-time install or version update, bump to version 0.2.6 Plugin._main no longer triggers an install, the UI will only trigger an checkInstallationStatus call once now
Here is the PR for the plugin template update: SteamDeckHomebrew/decky-plugin-template#34 |
@TrainDoctor what's next for this? |
Needs testing. @SteamDeckHomebrew/decky-testers please give this a shot and let me know if you encounter any issues. |
@wheaney apologies for the delay. I finally have time to give this a whirl tomorrow. If you can rebase it to latest main that'd make it much easier for me to test. |
I'm not sure what was going on with that first merge, but I think it's all sync'ed up now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good addition - can you remove the empty file and rebase? Will do some testing the next days.
@wheaney once this change is made I can pretty easily merge this. Thanks. |
The commit history here was confusing me, so I just rebased, removed the empty file, and force pushed. |
Mergin, thanks for this @wheaney ! |
* Add Plugin.uninstall callback support #536 * Remove empty deck.sh
* Add Plugin.uninstall callback support SteamDeckHomebrew#536 * Remove empty deck.sh
#536
Please tick as appropriate:
Description
This fixes issue: #536