-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bash Shortcuts to v2.0.0 #291
Update Bash Shortcuts to v2.0.0 #291
Conversation
…plugin-database into bash-shortcuts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python side good code wise, requested the more typescript and react side of the loader team to review that side of this PR before sending to testing.
Currently on:
Using a simple shortcut (with command: konsole), it seems to work just fine to boot as an app. However, apologies for my lack of knowledge how to properly test this plugin: got any command to test with, by any chance? To test the flags/hooks with at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On stable client/steam OS/decky and on the most recent version of bash shortcuts in the testing store.
All the features appear to work well, although I haven't tested every flag/hook.
The built-in documentation scrolls a little weirdly, but functions well enough and will likely be replaced by decky's #432 eventually anyways. The actual text in the docs is very helpful.
I've taken a look at the typescript and it all looks good, although I'm not a typescript master.
I think it looks good to go.
Bash Shortcuts Update v2.0.0
Bash Shortcuts is now feature complete.
Changes:
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing