-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix osx build #43
base: main
Are you sure you want to change the base?
Fix osx build #43
Conversation
Minor tweaks to the build commands to fix building on osx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'd recommend removing the windows entry for rsync since rsync is not a readily available command on windows.
Thank you for reviewing my code! |
Btw, I've also noticed another issue which is in the main.py file. One of the comments says this:
But the actual path is this:
Should I create a new PR to make this change, since it's sort of unrelated? |
Feel free to add it to this one. Better just to get it all up to date than to quibble. |
I've just realised the reason for this mismatch could be due to the decky-loader api 3.0 update. |
I just checked the logs, and it appears to be working with these changes even on the latest stable release of decky-loader. The logging is still working when importing decky rather than decky_plugin. I presume this is ready to merge now. |
I'll give it a final look today when I have time. I appreciate you being attentive and looking to catch important details. So often these text changes are just used to inflate a user's contribution stats etc so genuine effort like this is always appreciated. |
Thank you! I'm developing my own plugin anyway, so I thought I'd push any changes I had to make to the template myself. This is one of the best repositories to work on as a beginner contributor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, will merge when Loader Pre-Release goes to stable.
This is my first proper PR btw.
These are just some minor tweaks to the build commands to fix building on osx. The "cli-build" task just didn't run in the first place. There was an error when running the "copyzip" task, and the quick fix for me was to remove the chmod flag. There could be unintended side effects that I haven't noticed yet, so please let me know if this is an issue!
Thanks