Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support as 3.3 #89

Merged
merged 9 commits into from
Feb 5, 2019
Merged

Support as 3.3 #89

merged 9 commits into from
Feb 5, 2019

Conversation

StefMa
Copy link
Owner

@StefMa StefMa commented Jan 24, 2019 •
edited
Loading

This fixes #87 and #88 .

Currently I'm not 100 percent satisfied with the solution and there are few things to do:

  • Remove the afterEvaluated listener
  • 👆 I think that requires a Gradle 5.0 update
  • 👆 This required a site plugin update
  • Update all tests with the AbstractTest
  • Update consumer
  • Think about the versioning...

@StefMa StefMa force-pushed the support_as_3.3 branch 3 times, most recently from d95405a to 79b8c9a Compare January 24, 2019 15:43
@StefMa
Copy link
Owner Author

StefMa commented Feb 5, 2019

Currently the first three are not possible...
See #90

@StefMa StefMa force-pushed the support_as_3.3 branch 2 times, most recently from 3ba4732 to 4a2cde5 Compare February 5, 2019 13:50
@StefMa StefMa mentioned this pull request Feb 5, 2019
Open
@StefMa StefMa force-pushed the support_as_3.3 branch 8 times, most recently from e650d30 to e60eba4 Compare February 5, 2019 14:37
@StefMa StefMa merged commit 84b3f3e into master Feb 5, 2019
@StefMa StefMa deleted the support_as_3.3 branch February 5, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variant.getJavaCompiler is deprecated in AS 3.3
1 participant
@StefMa