-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating StelLogger #3614
Updating StelLogger #3614
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
OK, I'll install OpenBSD and run Stellarium tonight |
OK, OpenBSD is done |
@gzotti @10110111 @worachate001 please test and review this PR |
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
Hello @alex-w! Please check the latest stable version of Stellarium: |
Description
StelLogger previously obtaining many of hardware info through calling CLI tools, and it was caused persistent problem in some environments. Currently, these parts of code rewriting to using platform-specific API/code and format of data has unification form now. Of course, we can expand collected data.
Information for compiler name and version is coming from CMake now, and all related C++ code was removed.
The code is tested in these operating systems: Windows, macOS, Linux (Ubuntu and Raspberry OS), FreeBSD, OpenBSD, NetBSD, OpenIndiana, Haiku.
Type of change
How Has This Been Tested?
Checklist: