Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating StelLogger #3614

Merged
merged 46 commits into from
Feb 3, 2024
Merged

Updating StelLogger #3614

merged 46 commits into from
Feb 3, 2024

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Jan 30, 2024

Description

StelLogger previously obtaining many of hardware info through calling CLI tools, and it was caused persistent problem in some environments. Currently, these parts of code rewriting to using platform-specific API/code and format of data has unification form now. Of course, we can expand collected data.

Information for compiler name and version is coming from CMake now, and all related C++ code was removed.

The code is tested in these operating systems: Windows, macOS, Linux (Ubuntu and Raspberry OS), FreeBSD, OpenBSD, NetBSD, OpenIndiana, Haiku.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

  1. Run Stellarium
  2. Open Help windows, Log section
  3. See upper 10-12 lines of log

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111 and gzotti January 30, 2024 08:48
@alex-w alex-w added this to the 24.1 milestone Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added the infrastructure Infrastructure related issues label Jan 30, 2024
@alex-w alex-w marked this pull request as draft January 30, 2024 09:25
@alex-w
Copy link
Member Author

alex-w commented Jan 30, 2024

OK, I'll install OpenBSD and run Stellarium tonight

@alex-w alex-w marked this pull request as ready for review January 30, 2024 13:58
@alex-w
Copy link
Member Author

alex-w commented Jan 30, 2024

OK, OpenBSD is done

@alex-w alex-w requested a review from worachate001 January 31, 2024 03:23
@alex-w
Copy link
Member Author

alex-w commented Jan 31, 2024

@gzotti @10110111 @worachate001 please test and review this PR

src/StelLogger.cpp Outdated Show resolved Hide resolved
src/StelLogger.cpp Outdated Show resolved Hide resolved
src/StelLogger.cpp Outdated Show resolved Hide resolved
src/StelLogger.cpp Outdated Show resolved Hide resolved
src/StelLogger.cpp Outdated Show resolved Hide resolved
@alex-w alex-w requested a review from 10110111 February 3, 2024 15:45
@alex-w alex-w merged commit e57adf9 into master Feb 3, 2024
42 of 43 checks passed
@alex-w alex-w deleted the refactoring/logger branch February 3, 2024 16:35
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Feb 10, 2024
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 26, 2024
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issues
Development

Successfully merging this pull request may close these issues.

2 participants