Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app_accuracy.tex, minor edits #3674

Closed
wants to merge 2 commits into from

Conversation

hdquemada
Copy link
Contributor

@hdquemada hdquemada commented Mar 18, 2024

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for helping. We may take over a few changes, but not all. Will do that on Saturday.

@@ -33,9 +33,9 @@ \chapter{Accuracy}
the Solar gravity field, may still be required for critical
observations of stellar occultations by asteroids, grazing
occultations of stars by the Moon or similar things. Stellarium does
not compute these effects, and is definitely not capable for detailed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, if we are changing something, admittedly the program is not capable, humans may be. So "not usable for..."

planning of your spacecraft missions to the planets.
There are more specialized programs for these topics, please use them.
There are more specialized programs for these topics. Please use them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a particular large group of readers, somebody recommended using short sentences. I wanted to be understood. ;-)

@@ -63,7 +63,7 @@ \section{Stellar Proper Motion}
please note that the computation only takes the linear components $\Delta\alpha$, $\Delta\delta$ into account.
For times far from today, a true 3D computation would be required,
so that also changes in distance (and thus, brightness) could be simulated.
Still, the simulation here should give a good impression which close and/or fast stars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, which stars in detail, not just a general observation.

@@ -125,7 +125,7 @@ \section{Minor Bodies}

Positions for the Minor Bodies (Dwarf Planets, Asteroids, Comets) are
computed with standard algorithms found in astronomical text
books. The generally used method of orbital elements allows to compute
books. The generally used method of orbital elements allows the user to compute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably "allows computing". Not just the user of our program, but anybody who uses the scientific model.

@@ -164,7 +164,7 @@ \section{Eclipses}

The moon's motion is very complicated, and eclipse computations can be
tricky. One aspect which every student of history, prehistory and
archaeology should know but as it seems not every does, is at least a
archaeology should know, but as it seems not every does, is at least a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's a complete insertion.

@@ -202,17 +202,17 @@ \section{The Calendar}
\S189]{Ginzel:ChronologieII}. Be careful if you are working in
Augustean and earlier times in the Roman world, maybe even related to
named dates in the pre-Julian Roman calendar: Stellarium, also its
Calendars plugin (see section \ref{sec:plugin:Calendars}) does not
Calendars plugin (see section \ref{sec:plugin:Calendars}), does not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@@ -253,7 +253,7 @@ \section{Comparison to Reference Data}
provided by JPL's solutions DE440/DE441 in J2000.0 equatorial
coordinates, including JPL's corrections for nutation, light time,
aberration, light deflection in the Solar gravity field, and other
relativistic effects. The right part provides the according values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think this is in any way better, we can say "respective values". I want to express "these are the results of Stellarium 0.21.2β put next to/adjacent/side-to-side the results of JPL Horizons for the same input dates."

@hdquemada
Copy link
Contributor Author

hdquemada commented Mar 18, 2024 via email

@gzotti gzotti closed this in 6c869cc Mar 23, 2024
@alex-w alex-w added this to the 24.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants