-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app_accuracy.tex, minor edits #3674
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for helping. We may take over a few changes, but not all. Will do that on Saturday.
@@ -33,9 +33,9 @@ \chapter{Accuracy} | |||
the Solar gravity field, may still be required for critical | |||
observations of stellar occultations by asteroids, grazing | |||
occultations of stars by the Moon or similar things. Stellarium does | |||
not compute these effects, and is definitely not capable for detailed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, if we are changing something, admittedly the program is not capable, humans may be. So "not usable for..."
planning of your spacecraft missions to the planets. | ||
There are more specialized programs for these topics, please use them. | ||
There are more specialized programs for these topics. Please use them. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a particular large group of readers, somebody recommended using short sentences. I wanted to be understood. ;-)
@@ -63,7 +63,7 @@ \section{Stellar Proper Motion} | |||
please note that the computation only takes the linear components $\Delta\alpha$, $\Delta\delta$ into account. | |||
For times far from today, a true 3D computation would be required, | |||
so that also changes in distance (and thus, brightness) could be simulated. | |||
Still, the simulation here should give a good impression which close and/or fast stars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, which stars in detail, not just a general observation.
@@ -125,7 +125,7 @@ \section{Minor Bodies} | |||
|
|||
Positions for the Minor Bodies (Dwarf Planets, Asteroids, Comets) are | |||
computed with standard algorithms found in astronomical text | |||
books. The generally used method of orbital elements allows to compute | |||
books. The generally used method of orbital elements allows the user to compute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably "allows computing". Not just the user of our program, but anybody who uses the scientific model.
@@ -164,7 +164,7 @@ \section{Eclipses} | |||
|
|||
The moon's motion is very complicated, and eclipse computations can be | |||
tricky. One aspect which every student of history, prehistory and | |||
archaeology should know but as it seems not every does, is at least a | |||
archaeology should know, but as it seems not every does, is at least a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it's a complete insertion.
@@ -202,17 +202,17 @@ \section{The Calendar} | |||
\S189]{Ginzel:ChronologieII}. Be careful if you are working in | |||
Augustean and earlier times in the Roman world, maybe even related to | |||
named dates in the pre-Julian Roman calendar: Stellarium, also its | |||
Calendars plugin (see section \ref{sec:plugin:Calendars}) does not | |||
Calendars plugin (see section \ref{sec:plugin:Calendars}), does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
@@ -253,7 +253,7 @@ \section{Comparison to Reference Data} | |||
provided by JPL's solutions DE440/DE441 in J2000.0 equatorial | |||
coordinates, including JPL's corrections for nutation, light time, | |||
aberration, light deflection in the Solar gravity field, and other | |||
relativistic effects. The right part provides the according values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this is in any way better, we can say "respective values". I want to express "these are the results of Stellarium 0.21.2β put next to/adjacent/side-to-side the results of JPL Horizons for the same input dates."
Great! Glad to help. Of course, use only what you think is helpful. I will be going through the other parts of the guide as well, so I hope it will be of use.
…---
Hector
On Mar 18, 2024, at 5:30 PM, Georg Zotti ***@***.***> wrote:
@gzotti requested changes on this pull request.
Hi! Thanks for helping. We may take over a few changes, but not all. Will do that on Saturday.
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -33,9 +33,9 @@ \chapter{Accuracy}
the Solar gravity field, may still be required for critical
observations of stellar occultations by asteroids, grazing
occultations of stars by the Moon or similar things. Stellarium does
-not compute these effects, and is definitely not capable for detailed
OK, if we are changing something, admittedly the program is not capable, humans may be. So "not usable for..."
In guide/app_accuracy.tex <#3674 (comment)>:
> planning of your spacecraft missions to the planets.
-There are more specialized programs for these topics, please use them.
+There are more specialized programs for these topics. Please use them.
For a particular large group of readers, somebody recommended using short sentences. I wanted to be understood. ;-)
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -63,7 +63,7 @@ \section{Stellar Proper Motion}
please note that the computation only takes the linear components $\Delta\alpha$, $\Delta\delta$ into account.
For times far from today, a true 3D computation would be required,
so that also changes in distance (and thus, brightness) could be simulated.
-Still, the simulation here should give a good impression which close and/or fast stars
No, which stars in detail, not just a general observation.
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -125,7 +125,7 @@ \section{Minor Bodies}
Positions for the Minor Bodies (Dwarf Planets, Asteroids, Comets) are
computed with standard algorithms found in astronomical text
-books. The generally used method of orbital elements allows to compute
+books. The generally used method of orbital elements allows the user to compute
probably "allows computing". Not just the user of our program, but anybody who uses the scientific model.
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -164,7 +164,7 @@ \section{Eclipses}
The moon's motion is very complicated, and eclipse computations can be
tricky. One aspect which every student of history, prehistory and
-archaeology should know but as it seems not every does, is at least a
+archaeology should know, but as it seems not every does, is at least a
OK, it's a complete insertion.
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -202,17 +202,17 @@ \section{The Calendar}
\S189]{Ginzel:ChronologieII}. Be careful if you are working in
Augustean and earlier times in the Roman world, maybe even related to
named dates in the pre-Julian Roman calendar: Stellarium, also its
-Calendars plugin (see section \ref{sec:plugin:Calendars}) does not
+Calendars plugin (see section \ref{sec:plugin:Calendars}), does not
OK.
In guide/app_accuracy.tex <#3674 (comment)>:
> @@ -253,7 +253,7 @@ \section{Comparison to Reference Data}
provided by JPL's solutions DE440/DE441 in J2000.0 equatorial
coordinates, including JPL's corrections for nutation, light time,
aberration, light deflection in the Solar gravity field, and other
-relativistic effects. The right part provides the according values
If you think this is in any way better, we can say "respective values". I want to express "these are the results of Stellarium 0.21.2β put next to/adjacent/side-to-side the results of JPL Horizons for the same input dates."
—
Reply to this email directly, view it on GitHub <#3674 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQ5YA7JQ4W5T2YGCKEQDOTYY5MF5AVCNFSM6AAAAABE4KIRL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBUGIYDMMBSGA>.
You are receiving this because you were assigned.
|
Description
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: