Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize solar eclipse file name #3721

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

10110111
Copy link
Contributor

The default output file name for eclipse maps will now depend on locale.

Copy link

github-actions bot commented Apr 20, 2024

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

src/gui/AstroCalcDialog.cpp Outdated Show resolved Hide resolved
@alex-w alex-w added this to the 24.2 milestone Apr 20, 2024
@10110111 10110111 force-pushed the localize-eclipse-map-file-name branch from 593b57e to c072a86 Compare April 20, 2024 15:14
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@10110111 10110111 merged commit e3eaa69 into Stellarium:master Apr 20, 2024
14 of 15 checks passed
@10110111 10110111 deleted the localize-eclipse-map-file-name branch April 20, 2024 15:23
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Apr 21, 2024
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Jun 23, 2024
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants