Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Asia/Choibalsan time zone #3955

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix for Asia/Choibalsan time zone #3955

merged 1 commit into from
Oct 18, 2024

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Oct 18, 2024

Description

The fix is added alias for time zone Asia/Choibalsan.

Fixes #3953

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to the 24.4 milestone Oct 18, 2024
@github-actions github-actions bot requested review from 10110111 and gzotti October 18, 2024 02:07
Copy link

github-actions bot commented Oct 18, 2024

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w merged commit c9c72bb into master Oct 18, 2024
28 of 29 checks passed
@alex-w alex-w deleted the tz-Asia-Choibalsan branch October 18, 2024 03:31
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 22, 2024
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TimeZone for "Baruun-Urt" not found: "Asia/Choibalsan"
1 participant