-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve star catalog documentation #3976
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
ca9f934
to
6132e86
Compare
Did you tested the code on big-endian and little-endian systems? |
Only tested on little-endian. Unfortunately I do not have any big-endian computer :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the struct
make sense to me. I don't think there's any endianness-related problem to be expected, since all that's changed there is the names of the same-sized objects as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@10110111 please merge the PR
Hello @henrysky! Please check the fresh version (development snapshot) of Stellarium: |
Hello @henrysky! Please check the latest stable version of Stellarium: |
Description
I have improved the readability of Star1 structure by put meaningful variable name in Star1 cpp code as well as fixing number error in the star catalog appendix.
The motivation of this PR is I am experimenting and looking into possible ways to improve star catlogs in Stellarium and want to make little changes without any breaking/new features first.
Fixes # (issue)
N/A
Screenshots (if appropriate):
N/A
Type of change
How Has This Been Tested?
I Don't expect there will be any breaking changes nor introduce any new feartures.
Test Configuration:
N/A
Checklist: