Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to resolve HIP first in search via SIMBAD #3980

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

henrysky
Copy link
Contributor

Description

In the search functionality via SIMBAD, stellarium should at least attempt to resolve the HIP number before trying the main identification IDLIST(1) from SIMBAD.

Because there can be scenario where one searches TIC 211277570 and stellarium points to a custom object * tet01 Sgr near HIP 98412 (TIC 211277570 is HIP 98412).

Fixes # (issue)

Screenshots (if appropriate):

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Compiled and ran.

Tried to search TIC 211277570 which point to the right star. Tried to search SDSS J140312.52+542056.2 which correctly point to M101 who does not have a HIP id.

Test Configuration:

  • Operating system: MacOS 15
  • Graphics Card: Apple M3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 24.4 milestone Nov 19, 2024
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit bd87bc1 into Stellarium:master Nov 19, 2024
14 of 15 checks passed
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Hello @henrysky!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @henrysky!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants