Attempt to resolve HIP first in search via SIMBAD #3980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the search functionality via SIMBAD, stellarium should at least attempt to resolve the HIP number before trying the main identification
IDLIST(1)
from SIMBAD.Because there can be scenario where one searches
TIC 211277570
and stellarium points to a custom object* tet01 Sgr
nearHIP 98412
(TIC 211277570
isHIP 98412
).Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Compiled and ran.
Tried to search
TIC 211277570
which point to the right star. Tried to searchSDSS J140312.52+542056.2
which correctly point to M101 who does not have a HIP id.Test Configuration:
Checklist: