Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep FOV search radius on hiDPI screen consistent from user perspective #3985

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

henrysky
Copy link
Contributor

Description

I briefly looked into the issue #3733 because the issue of selecting the wrong star/ not selecting any stars even clicked near a star somewhat are becoming more problematic when some sky regions can have stars densely packed together with future star catalogs with Gaia. Although this PR does not fix anything, but a minor logical improvement until someone takes a deep dive into the issue after the new star catalogs are done because things can still be changed around.

I've found that the FOV to search around are penalized for user with a scaled high DPI screen by the display scaling factor. So hiDPI screen users are expected to click closer to a star in order for it to be searched. Now the FOV to search should be independent of display scaling (N pixels from user perspective around the mouse click will be searched)

Fixes # (issue)

None

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: MacOS 13
  • Graphics Card: Apple M3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, right, thanks!

@alex-w alex-w added this to the 24.4 milestone Nov 24, 2024
@alex-w alex-w added the hw: hdpi Specific issues for HPDI-devices label Nov 24, 2024
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit d61fbe7 into Stellarium:master Nov 24, 2024
16 checks passed
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Hello @henrysky!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @henrysky!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw: hdpi Specific issues for HPDI-devices
Development

Successfully merging this pull request may close these issues.

3 participants