Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.ini #3990

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Update info.ini #3990

merged 1 commit into from
Nov 29, 2024

Conversation

Jonas-Persson-NTNU
Copy link
Contributor

@Jonas-Persson-NTNU Jonas-Persson-NTNU commented Nov 29, 2024

I updated my email, as it has been hard to contact me with questions.

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I updated my email, as it has been hard to contact me with questions.
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?
  • Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w reopened this Nov 29, 2024
@alex-w alex-w added this to the 24.4 milestone Nov 29, 2024
@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Nov 29, 2024
@alex-w alex-w merged commit 261a029 into Stellarium:master Nov 29, 2024
7 of 8 checks passed
@Jonas-Persson-NTNU Jonas-Persson-NTNU deleted the patch-1 branch November 29, 2024 08:15
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Hello @Jonas-Persson-NTNU!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @Jonas-Persson-NTNU!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: skycultures The issue is related to skycultures of planetarium...
Development

Successfully merging this pull request may close these issues.

2 participants