Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

유저 통합 테스트 완성 #81

Merged
merged 10 commits into from
Oct 26, 2023
Merged

유저 통합 테스트 완성 #81

merged 10 commits into from
Oct 26, 2023

Conversation

jagaldol
Copy link
Member

Summary

유저 통합 테스트 작성을 완료하였습니다. 테스트 코드 작성하며 발견한 이슈 #78 / #80 도 해결하였습니다.

Description

각 api들의 테스트들을 작성하였습니다.

Related Issue

Issue Number: #63, close #78, close #80

@jagaldol
feat: Enable null query 'name' of GET /users
7b0807d 
name이 없을 시 전체 사용자에 대해 검색해서 줌

resolve: #78
@jagaldol
test: Create Test of GET /users
28d0237
@jagaldol
test: Create Test of GET /users/:userId
47c6087
@jagaldol
test: Create Test of GET /users/mine
2bf5a92
@jagaldol
fix: Edit Typo of 'RUQUEST'
16c2f19
@jagaldol
fix: Remove request and Access direct name, districtId
9131da9 
- api 명세서대로 동작하지 않아 수정
- RequestPart를 점수 등록/수정과 동일하게 RequestParam으로 변경
- validation의 로직을 service로 이동
- 각 요소에 전부 null 허용
@jagaldol
fix: Move to do Null Check Properly
c2b71dd
@jagaldol
test: Create Test of PUT /users/mine
e755562 
s3의 경우 mock으로 처리
@jagaldol
test: Create Test case of only edit name/profileImage
1368bdd
@jagaldol
test: Create Test of GET /users/:userId/records
f7c5094
@jagaldol jagaldol added the Type: Maintenance refactoring 등 코드 개선 및 유지 보수 label Oct 25, 2023
@jagaldol jagaldol self-assigned this Oct 25, 2023
yunzae
yunzae approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@yunzae yunzae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다👍

@jagaldol jagaldol merged commit c418a47 into weekly/8-9 Oct 26, 2023
@jagaldol jagaldol deleted the feat/controller-test branch October 26, 2023 22:15
This was referenced Nov 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunzae yunzae yunzae approved these changes

@sososo0 sososo0 Awaiting requested review from sososo0

@xcelxlorx xcelxlorx Awaiting requested review from xcelxlorx

Assignees

@jagaldol jagaldol

Labels
Type: Maintenance refactoring 등 코드 개선 및 유지 보수
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

개인정보 수정 api 버그 사용자 목록 검색 GET /api/users query parameter 수정
2 participants
@jagaldol @yunzae