#175 서비스 코드 통합 #202
Merged
#175 서비스 코드 통합 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/bookmark/service/BookmarkService.java
Show resolved
Hide resolved
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/bookmark/service/BookmarkService.java
Show resolved
Hide resolved
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/share/service/category/ShareCategoryService.java
Show resolved
Hide resolved
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/bookmark/service/BookmarkService.java
Show resolved
Hide resolved
Train0303
reviewed
Nov 8, 2023
Comment on lines
+88
to
+92
| public void addBookmark(BookmarkRequestDto.BookmarkAddDto bookmarkAddDto, User user) { | ||
| // Bookmark 테이블에 bookmark 항목 추가 | ||
| Category category = categoryService.findByIdFetchJoinWorkspace(bookmarkAddDto.getCategoryId()); | ||
|
|
||
| validUser(category, user); |
There was a problem hiding this comment.
@Transactional 추가 부탁드립니다.
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/bookmark/service/BookmarkService.java
Show resolved
Hide resolved
Train0303
reviewed
Nov 8, 2023
linknamu/src/main/java/com/kakao/linknamu/bookmark/service/BookmarkService.java
Show resolved
Hide resolved
|
제가 해당 수정부분 체크해서 다시 PR 올리겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용