Add config_flow for configuration via Integrations UI #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @YodaDaCoda , I had a quick look and it looks good. Will test and update the documentation likewise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly taken from my own attempt at creating the same custom component - https://github.com/YodaDaCoda/hass-solarman-modbus/
I note that your README.md includes a configuration parameter
scan_intervalwhich appears unused. I've not attempted to add that parameter.NB: during config flow, a connection attempt is made to the specified host/port combination. If this fails (e.g. because you're setting it up at night and the inverter/sensor is powered off) then setup will fail and the integration will not be added.
Fixes #15
My editor also removed some excess whitespace, I hope that's not an issue.