-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MSN wizz on nudge #655
feat: MSN wizz on nudge #655
Conversation
I'm willing to add a CSS animation however I don't think adding an mp3 sound is ideal for numerous reasons including security concerns and annoying people. If you want to remove the MP3 but keep the animation I'd be happy to accept the PR, otherwise I would suggest building your own fork with the feature for self hosting. |
Hello @StevenWeathers, thanks for your feedback, it makes sense indeed. |
I think the idea of adding a config option makes sense however at this time I do not want to add sound files to the application build. |
Certainly, I understand. |
Description
This pull request introduces a fun and nostalgic feature by adding an MSN Wizz animation and sound effect when a user is nudged during a poker game. The changes include:
Many thanks to @kesslerdev for the suggestion.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots/Recordings
Steps to QA