GDPR Update

[Liviu-p]

No description provided.

[coderabbitai]

Walkthrough

This pull request introduces GDPR-related settings and modifications across multiple files in a WordPress plugin. The changes include adding new methods and properties to handle GDPR cookie settings, updating the settings view to include GDPR-specific options, and modifying the get_ajax_redirect_response_data method in the forms controller. The primary focus is on enhancing privacy controls and providing more granular options for managing user tracking and data collection.

Changes

File	Change Summary
classes/controllers/FrmFormsController.php	- Changed get_ajax_redirect_response_data method from private to public - Simplified content assignment in the method
classes/helpers/FrmAppHelper.php	- Added new no_gdpr_cookies() static method to check GDPR cookie settings
classes/models/FrmSettings.php	- Added two new properties: enable_gdpr and no_gdpr_cookies - Updated default_options and update_settings methods to support new GDPR-related settings
classes/views/frm-settings/general.php	- Renamed "Other" header to "Defaults" - Added new "GDPR" section with checkboxes for GDPR features and cookie tracking

Sequence Diagram

sequenceDiagram
    participant User
    participant Settings
    participant AppHelper
    participant FormSettings

    User->>Settings: Enable GDPR options
    Settings->>FormSettings: Update GDPR settings
    FormSettings-->>Settings: Confirm settings update
    Settings->>AppHelper: Check GDPR cookie status
    AppHelper-->>Settings: Return GDPR cookie setting

Loading

Possibly related PRs

• Add redirect delay settings #2117: Modifies FrmFormsController class, enhancing the get_ajax_redirect_response_data method
• fix failling unit test in php 7.4 #2213: Updates get_ajax_redirect_response_data method, adding a new key to the response data array

Suggested labels

action: needs qa, run analysis, deploy, run tests

Suggested reviewers

• Crabcyborg

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d0b0dc and e0f2132.

📒 Files selected for processing (4)

• classes/controllers/FrmFormsController.php (1 hunks)
• classes/helpers/FrmAppHelper.php (1 hunks)
• classes/models/FrmSettings.php (2 hunks)
• classes/views/frm-settings/general.php (2 hunks)

🔇 Additional comments (4)

classes/views/frm-settings/general.php (1)

57-87: LGTM! The GDPR settings section is well implemented.

The GDPR settings section is properly organized with:

• Clear section heading
• Conditional visibility for GDPR options
• Proper escaping and sanitization
• Clear descriptions for each setting

classes/models/FrmSettings.php (1)

153-154: LGTM! The GDPR settings are properly integrated.

The new GDPR settings are correctly:

• Defined as properties
• Initialized with default values
• Added to the update logic

Also applies to: 403-403

classes/controllers/FrmFormsController.php (1)

2797-2797: Skipping review of unrelated changes.

The changes in this file are not related to the GDPR functionality.

classes/helpers/FrmAppHelper.php (1)

4383-4394: LGTM! The GDPR helper method is well implemented.

The no_gdpr_cookies() method:

• Provides a clean API for checking GDPR cookie settings
• Uses proper type casting
• Follows single responsibility principle

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.