Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOAL-1240] Add new parameters to user jwt #19

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jorgejimenez-stratio
Copy link

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

PLACE RELEASE NOTES HERE

uid = userinfo["user"],
username = userinfo["username"],
tenants = userinfo["tenants"],
equipo = "gosec"
Copy link
Collaborator

@Alvaro-Campesino Alvaro-Campesino Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sólo porque lo he visto cuando nos comentábais esto.
¿No sería mejor si todas las variables son en inglés mantenenerlo así?.

Suggested change
equipo = "gosec"
team = "gosec"

Que igual al ser prueba esto no va luego a ningún sitio, pero bueno, por si acaso.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si perdona, es una prueba para una poc, de hecho ese campo ni va a ir, solo era para testear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants