fix: workaround to make Airplay work on Safari #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclekingpin
requested changes
Jun 11, 2024
| var source = document.createElement('source'); | ||
| source.src = stream.url; | ||
| videoElement.appendChild(source); | ||
| videoElement.disableRemotePlayback = false; |
There was a problem hiding this comment.
could this be moved on line 28?
There was a problem hiding this comment.
No, this has to be done after calling hls.attachMedia(videoElement); and media is attaching, hence this is done on the Hls.Events.MEDIA_ATTACHING event.
I tested this with many other variations and this is the only way that got it working.
| function attachOriginalSource() { | ||
| var source = document.createElement('source'); | ||
| source.src = stream.url; | ||
| videoElement.appendChild(source); |
There was a problem hiding this comment.
we need to add the corresponding action in the unload command handler after the videoElement.removeAttribute('src'); call
something like:
while (videoElement.child) videoElement.removeChild(videoElement.child)
|
Any update on this? |
|
It's ready to be merged for a long time on my end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the suggested workaround from this comment to make Airplay work in Safari.
For some reason, audio doesn't play on Airplay on my TV, but I think this should probably be handled on the streaming server.
Previously, using Airplay didn't work at all, so this PR is still an improvement since the video is now displayed on the target device properly.
Airplay support was added to the player of Stremio Web in this PR: Stremio/stremio-web#629