Show fullscreen button on Safari desktop PWA #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I personally don't think this change is needed at all, as we already have a full screen button in the native app action buttons, while running PWA on macOS. Leaving the review to @tymmesyde
|
|
The fullscreen button is completely unnecessary in Stremio web, but this makes the Safari PWA experience consistent with other browsers. |
unclekingpin
requested changes
Dec 8, 2023
|
On Chrome on Android, you can enter fullscreen mode and on iOS it would be hidden since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Safari adding PWA support on desktop,
window.navigator.standaloneis no longer only true on iOS.