Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Side Drawer component implementation inside the Player #735

Merged
merged 53 commits into from
Dec 24, 2024

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Dec 6, 2024

Change log

  • Adds a desktop app like SideDrawer component that unites InfoMenu and VideosMenu into one component.
  • Deletes unused InfoMenu and VideosMenu
  • Now the I shortcut opens the SideDrawer instead of the old InfoMenu

Needs:

Reference for inert attribute

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inert

TODO:

For testers

@kKaskak kKaskak added the enhancement New feature or request label Dec 6, 2024
@kKaskak kKaskak self-assigned this Dec 6, 2024
@kKaskak kKaskak changed the title feat: init side drawer component feat: Side Drawer component implementation inside the Player Dec 9, 2024
@kKaskak kKaskak requested a review from tymmesyde December 9, 2024 16:19
@kKaskak kKaskak requested a review from elpiel December 12, 2024 10:58
tymmesyde
tymmesyde previously approved these changes Dec 18, 2024
@elpiel
Copy link
Member

elpiel commented Dec 20, 2024

On mobile (like this simulation of S20 Ultra) I don't see the back button though. On vertical orientation it's there.
I tried scrolling but no result, only the details show up

PS: Only sharing my findings, I think it's fine like this as you see the player so you can click on it to close it

image
image

elpiel
elpiel previously approved these changes Dec 20, 2024
@kKaskak
Copy link
Member Author

kKaskak commented Dec 20, 2024

On mobile (like this simulation of S20 Ultra) I don't see the back button though. On vertical orientation it's there.
I tried scrolling but no result, only the details show up

PS: Only sharing my findings, I think it's fine like this as you see the player so you can click on it to close it

image
image

Thank you. Yes exactly this was the idea for the close button to be present only in portrait mode, since normally you "click" out to close it, same as on desktop.

@tymmesyde tymmesyde dismissed stale reviews from elpiel and themself via c83f3e8 December 24, 2024 13:52
@tymmesyde tymmesyde merged commit e74924b into development Dec 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants