-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Side Drawer component implementation inside the Player #735
Conversation
dvh solves an issue where without fullscreen not all videos in the list are fully visible since vh does not count the safe / unsafe area
refactor: rewrite sidedrawer to act like a menu
Thank you. Yes exactly this was the idea for the close button to be present only in portrait mode, since normally you "click" out to close it, same as on desktop. |
…into feat/player-side-drawer
Change log
SideDrawer
component that unitesInfoMenu
andVideosMenu
into one component.InfoMenu
andVideosMenu
I
shortcut opens theSideDrawer
instead of the oldInfoMenu
Needs:
MarkVideoAsWatched
in the Player model | Done by @tymmesyde ✅feat: add player MarkVideoAsWatched action stremio-core#750
stremio-icons
PR that will add the newEpisodes
iconrefactor: update episodes icon stremio-icons#25
Reference for
inert
attributehttps://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inert
TODO:
For testers