Add "join lobby"-button #39
Open
+107
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Löfgren <[email protected]>
The browser extension will insert a join lobby button on the wikiweaverserver domain specified by the user. When pressed, this will join the currently open lobby with stored username. The user most have specified a username beforehand. Note: it uses the activeTab permission (instead of permission on allurls) to be able to insert itself on only the currently active tab. Thismeans that the user must be on the website and open (or have open) theextension. The current tab is only part of the activeTab permissionbased on user interaction, e.g. opening the extension. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#activetab_permission Signed-off-by: Victor Löfgren <[email protected]>
|
This does not interact well with the #36 currently. You need to minimize the extension and then open it again for the join button to appear. |
sornas
reviewed
Jan 17, 2025
Signed-off-by: Victor Löfgren <[email protected]>
|
ok so it's a bit unfortunate that you have to have the extension loaded to be able to use this button, but it makes sense from a permissions perspective. in the end it's better to have this feature than not. one thing i would like is if the username is saved on every keypress. if no username has been stored, i can't seem to save the username without joining a lobby. |
sornas
approved these changes
Jan 19, 2025
|
i see this has the same commit regarding auto-loading settings as #34, so that discussion also applies here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Dynamically adds a join lobby button to the website by the browser extension on the domain specified in wikiweaver server. Hopefully frontend/backend is hosted on the same domain, but we could extend this later if we need that.
Note that you must have the browser extension open on for the permissions to kick in, it wont be able to insert the button otherwise. More on that in the commit message.