Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #208

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
6 changes: 3 additions & 3 deletions wikipedia-dark.user.css
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,10 @@
.mw-body-content .portal ul,
.wikitable > tr,
.wikitable > tr > th,
.wikitable > tr > td,
.wikitable > * > tr,
.wikitable > tr > td:not([style*="background-color"]),
.wikitable > * > tr:not([bgcolor]),
.wikitable > * > tr > th,
.wikitable > * > tr > td:not(.break),
.wikitable > * > tr > td:not(.break):not([style*="color"]):not([style*="background"]):not([bgcolor]),
.wikitable th span[style*="background"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a high potential for collateral damage, especially given the amount of custom wikitable colors and styles employed on Wikipedia. Until they have more specific fixes, this rule remains necessary.

I would be hesitant to accept this change without reviewing quite a few wikitables with color scales to ensure it has the desired effect. We man find this starts an endless game of whack-a-mole.

.inline-quote-talk,
.oo-ui-fieldsetLayout-group .oo-ui-widget,
Expand Down