experiment: allow sideloading files from fs.FS #1160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Oct 2, 2024
| @@ -79,14 +83,13 @@ func InputFromPaths(paths []string) (Input, error) { | |||
| go func(path string) { | |||
| defer wg.Done() | |||
|
|
|||
| result, err := loader.RegoWithOpts(path, parse.ParserOptions()) | |||
There was a problem hiding this comment.
What this helper did for us isn't much, so I've inlined it below, added the indirection to read from fs.FS.
srenatus
force-pushed
the
sr/allow-sideloading-rego-files
branch
from
bb9adee to
33b9c12
Compare
srenatus
changed the title
srenatus
force-pushed
the
sr/allow-sideloading-rego-files
branch
3 times, most recently
from
31bff9a to
61add84
Compare
anderseknert
reviewed
Oct 2, 2024
Merged
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/allow-sideloading-rego-files
branch
from
61add84 to
ecc3947
Compare
|
Not today 🧹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualInputThe reason for this: in EOPA, we've got a bunch of rego helper functions, and we'd like the LSP to be aware of them for code completion. This would seem like a decent approach to make it aware of them.
(The actual code completion UX still depends on #1145, because that is how the utility methods are advertised to be used.)