bundle: Add non-loop-expression rule #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
non-loop-expression
branch
from
7ff418f to
17c58e3
Compare
charlieegan3
force-pushed
the
non-loop-expression
branch
from
17c58e3 to
094959e
Compare
charlieegan3
force-pushed
the
non-loop-expression
branch
from
094959e to
6f8b1ec
Compare
anderseknert
approved these changes
Feb 11, 2025
| @@ -18,6 +18,8 @@ items contains item if { | |||
| position := location.to_position(input.regal.context.location) | |||
| line := input.regal.file.lines[position.line] | |||
|
|
|||
| not endswith(trim_space(line), "=") | |||
There was a problem hiding this comment.
👏
There's nothing better than writing a Regal rule that finds issues in Regal.
bundle/regal/rules/performance/non-loop-expression/non_loop_expression.rego
Outdated
Show resolved
Hide resolved
bundle/regal/rules/performance/non-loop-expression/non_loop_expression.rego
Outdated
Show resolved
Hide resolved
| `) | ||
|
|
||
| sps == {"0": { | ||
| 5: { |
There was a problem hiding this comment.
Interesting how the first level variable can't be numeric (due to that type checker bug), but seems to work for this next level. That should be fixed of course, but certainly out of scope for this PR :)
There was a problem hiding this comment.
yeah this was an ongoing pain when working on this one
There was a problem hiding this comment.
I'm hoping that @johanfylling can fix that in OPA soon :)
bundle/regal/rules/performance/non-loop-expression/non_loop_expression_test.rego
Outdated
Show resolved
Hide resolved
|
|
||
| ## Exceptions | ||
|
|
||
| This rule cannot yet detect the following cases. |
Fixes StyraInc#93 Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Like we predicted, this rule costs a lot. 6 million allocations compared to main is probably a record! But the value of the rule is also great, so we'll have to make the best of it. Some perf tweaks help shave off at least 1 million allocations, and we're now down to 5. Next up, I'll be taking a look at where most of the cost in OPA is while evaluating this. Funnily, I also found a missing case in the `use-object-keys` rule I added just today, from seeing a set comprehension being used to get keys but not getting flagged by the rule. Turned out `object.keys` was also noticeably faster :) ``` 1872039250 ns/op 3277562680 B/op 64585680 allocs/op // main 1990034458 ns/op 3577600880 B/op 70427856 allocs/op // non-loop-expression PR 1981020667 ns/op 3515957384 B/op 69337090 allocs/op // use built-ins to get _exprs row 1976604792 ns/op 3518227272 B/op 69422952 allocs/op // inline ast.is_wildcard 1957780375 ns/op 3518962424 B/op 69226825 allocs/op // uglier loops 1923554667 ns/op 3501324176 B/op 68954057 allocs/op // object.keys(sps) ``` Signed-off-by: Anders Eknert <[email protected]>
This will be detected by another rule. Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
non-loop-expression
branch
from
1210a55 to
daa95a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
TODO:
printstatements