-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add network policies reference #425
Conversation
Can you move your content to another file and include it in the index (Cf #424) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I made some comments on some flows, let me know if you think they are relevant!
docs/source/reference/index.rst
Outdated
+--------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------+ | ||
| Pod | Incoming | Outgoing | | ||
+==========================+=========================================================================================================================================+=====================================================================================================================================+ | ||
| orchestrator-server | backend-api-events, backend-worker-events, backend-scheduler, backend-scheduler-worker, backend-server, backend-builder, backend-worker | orchestrator-database | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incoming also from internet, for other organisations. Basically it is opened to everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with prefacing that all these connections come from other organisations?
The idea is to give the option, if people deploying the network are using a more advanced network plugin, to know what connections exactly need to be allowed
docs/source/reference/index.rst
Outdated
+==========================+=========================================================================================================================================+=====================================================================================================================================+ | ||
| orchestrator-server | backend-api-events, backend-worker-events, backend-scheduler, backend-scheduler-worker, backend-server, backend-builder, backend-worker | orchestrator-database | | ||
+--------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------+ | ||
| orchestrator-database | orchestrator-server | NONE | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incoming: also orchestrator-migrations
docs/source/reference/index.rst
Outdated
| orchestrator-server | backend-api-events, backend-worker-events, backend-scheduler, backend-scheduler-worker, backend-server, backend-builder, backend-worker | orchestrator-database | | ||
+--------------------------+-----------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------+ | ||
| orchestrator-database | orchestrator-server | NONE | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All pods are given access to kube-dns
on port 53, I don't know if it worth specifying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there cases where pods in kube are not given access to the DNS resolver?
maybe I can add a footnote to cover all cases?
docs/source/reference/index.rst
Outdated
It defines a set of roles (minimal network policies that block or allow a given connection) and relies on label selectors | ||
to apply these roles to appropriate pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SIn some, we also uses IP ranges
ac171a0
to
b79d5e6
Compare
Signed-off-by: SdgJlbl <[email protected]>
b79d5e6
to
5cb702c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes fl-1580