Skip to content

Commit

Permalink
Revert "feat: expose the CP submission batch size in execute_experime…
Browse files Browse the repository at this point in the history
…nt (#21)"

This reverts commit b83cd5e.
  • Loading branch information
ThibaultFy committed Dec 13, 2022
1 parent 61a82d4 commit f8c6f32
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions substrafl/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ def execute_experiment(
clean_models: bool = True,
name: Optional[str] = None,
additional_metadata: Optional[Dict] = None,
task_submission_batch_size: int = 500,
) -> substra.sdk.models.ComputePlan:
"""Run a complete experiment. This will train (on the `train_data_nodes`) and test (on the
`test_data_nodes`) your `algo` with the specified `strategy` `n_rounds` times and return the
Expand Down Expand Up @@ -264,10 +263,7 @@ def execute_experiment(
quickly so should be set to True unless needed. Defaults to True.
name (str, Optional): Optional name chosen by the user to identify the compute plan. If None,
the compute plan name is set to the timestamp.
additional_metadata(dict, typing.Optional): Optional dictionary of metadata to be passed to the Substra WebApp.
task_submission_batch_size(int): The compute plan tasks are submitted by batch. The higher the batch size,
the faster the submission, a batch size that is too high makes the submission fail.
Rule of thumb: batch_size = math.floor(120000 / number_of_samples_per_task)
additional_metadata(dict, Optional): Optional dictionary of metadata to be passed to the Substra WebApp.
Returns:
ComputePlan: The generated compute plan
Expand Down Expand Up @@ -369,8 +365,6 @@ def execute_experiment(
name=name or timestamp,
metadata=cp_metadata,
),
auto_batching=True,
batch_size=task_submission_batch_size,
)
logger.info(("The compute plan has been registered to Substra, its key is {0}.").format(compute_plan.key))
return compute_plan

0 comments on commit f8c6f32

Please sign in to comment.