-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jQuery UI draggable support #16
Comments
@edmundquintero, thoughts on the draggable changes for v1.1? |
I have jQueryUI running in my test env now but I have a few questions about implementation. @ddoolin suggests using both a variable and a priority. This would mean |
@edmundquintero I think that the mark-up would become too verbose at that point. Draggable settings should be on the full set, not individual objects. To play off your idea of disabling individual objects though, we could go this route: <packery draggable="[dragabilly, jquery]">
<packery-object no-drag></packery-object>
</packery>
I think straying from Packery's default of no dragging was caused by us implementing our project's needs, where packed objects will rarely not be draggable. I think we should fall back to the core defaults and add enhancements where possible (such as individual "no-drag" objects). |
Packery accepts both Draggabilly and jQuery UI support. Currently, angular-packery only allows for Draggabilly support.
One thought is that the
draggable
attribute should be reworked to accept the following values:boolean
jquery
draggabilly
as opposed to the currentboolean
only method. We'd need to take this into consideration when addressing issue #13.I also think that the
draggable
option should default tofalse
and Draggabilly should be removed from the Bower dependencies.The text was updated successfully, but these errors were encountered: