Added drag support for jQueryUI. #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2015 16:53
|
In the event we like this let me know and I will update the README as well with jQueryUI as an optional library. |
| @@ -205,7 +258,7 @@ | |||
| if (scope.isResizeBound === 'false') { scope.isResizeBound = false; } | |||
|
|
|||
| // Set global draggability | |||
| if (scope.draggable) { controller.setDraggable(scope.handle); } | |||
| scope.draggable = (scope.draggable) ? controller.setDraggable(scope.draggable, scope.handle) : angular.noop(); | |||
There was a problem hiding this comment.
When would this evaluate to false?
There was a problem hiding this comment.
When draggable is not an attribute the packery-object I believe. Ill need to test that.
There was a problem hiding this comment.
I specifically meant scope.draggable = (scope.draggable). Wouldn't that always be true?
…ggable as attribute on packery element
REVISED :
|
| draggable: true, | ||
| handle: '*', | ||
| draggable: undefined, | ||
| handle: undefined, |
There was a problem hiding this comment.
Let's remove these before merge.
There was a problem hiding this comment.
Removing these declarations will create a need to revisit the link function in the packeryDirective.
scope.draggable = scope.draggable || config.draggable;
scope.handle = scope.handle || config.handle;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for jQueryUI.
Conditionals check for
draggableattribute on thepackery-objectto be set to 'draggabilly', 'jqueryui', or 'unsupported'If
draggableis left undefined thewindowis checked forDraggabillythenjQuery.ui. If neither are present then no drag functionality is added.Console warnings let the user know if they are specifically requesting a library and the library is not present.
ie.
draggable='draggabilly'and draggabilly.js is not included.