ENH: Add "ReduceDimension" option to ImageSampler components #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
commented
Mar 22, 2024
|
|
||
| if (m_ReduceDimension) | ||
| { | ||
| m_CroppedInputImageRegion.GetModifiableSize().back() = 1; |
There was a problem hiding this comment.
@mstaring @stefanklein It does not seem to be necessary to also adjust the index (by doing index[N-1] = 0, maybe), but that depends on the use case, I guess... See #1064 (comment)
|
At today's internal elastix sprint, we (@mstaring, @stefanklein) agreed to use a different name for the new parameter: |
Allows elastix users to specify that the image sampling is used for group-wise registration:
(UseSamplingForGroupwiseRegistration "true")
Aims to implement a generalization to the ReducedFullSampler, pull request #52 proposed by Mathias Polfliet in 2018.
N-Dekker
force-pushed
the
ImageSampler-ReduceDimension
branch
from
e03c538 to
b41eb07
Compare
|
The parameter is now renamed to "UseSamplingForGroupwiseRegistration", but Stefan (@stefanklein) suggested to double-check if it can really be applied to any groupwise registration. For BendingEnergy, it may not be appropriate.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows reducing the dimensionality of any image sampler by a new elastix parameter:
Aims to implement a generalization to the ReducedFullSampler, pull request #52 proposed by Mathias Polfliet (@MathiasPolfliet) in 2018.