STYLE: Remove sigma4factor from StochasticGradientDescent Optimizers
#1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local variable `sigma4factor` has been equal to `1.0` for more than 16 years. (Starting with commit a90c96a, 16 Jan 2008).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local variable
sigma4factorhas been equal to1.0for more than 16 years. (Starting with commit a90c96a, 16 Jan 2008).@stefanklein Looks like you introduced this constant with 27f26bf and then set it to
1.0with the next commit (a90c96a), on the very same day, 16 Jan 2008. Do you agree that it may be removed now?