-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Upgrade ITK from v5.2.0 to v5.3rc03 #620
Conversation
Upgraded to ITK version 5.3 (RC03), which was tagged on 16 January 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc03 Including upgrade to C++14, and various performance improvements: InsightSoftwareConsortium/ITK@6a8569e Use the faster `TransformPhysicalPointToContinuousIndex` overload InsightSoftwareConsortium/ITK@eb6ac88 Use the faster `TransformPhysicalPointToIndex` overload in filter InsightSoftwareConsortium/ITK@0539a2c Remove protected `itk::Transform` data member `m_DirectionChange` InsightSoftwareConsortium/ITK@eec9fe6 Remove unnecessary `IdentityTransform::m_ZeroJacobian` InsightSoftwareConsortium/ITK@9961ccd Use FastEvaluate in MattesMutualInformationImageToImageMetric + v4 InsightSoftwareConsortium/ITK@9745409 Use FixedArray for table within BSplineInterpolationWeightFunction InsightSoftwareConsortium/ITK@c23944b Remove BSplineInterpolationWeightFunction Kernel, use FastEvaluate InsightSoftwareConsortium/ITK@bc7c5df Use FixedArray for BSplineBaseTransform ParameterIndexArrayType InsightSoftwareConsortium/ITK@9bf745b Use FixedArray for BSplineInterpolationWeightFunction OutputType InsightSoftwareConsortium/ITK@c64a58d Make `ResampleImageFilter::LinearThreadedGenerateData` faster Follow-up to pull request #475 commit 6803b26 "COMP: Upgrade ITK from v5.1.1 to v5.2.0" (merged on 31 May 2021). Note: The last elastix git revision on the develop branch that still supported ITK 5.2 was tagged: "last-itk5.2-support"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For the record, the code adjustment in the five C++ source files included with this commit (all of them related to BSpline) were necessary because of a change in the definition of |
Code like `WeightsType weights(n)` does not necessarily construct an object of `n` weights, as it did before ITK 5.3. It now fills a fixed array of weights by value `n`. This behavior change is caused by a change of the definition of `itk::BSplineInterpolationWeightFunction::WeightsType`, by ITK pull request InsightSoftwareConsortium/ITK#2712 commit InsightSoftwareConsortium/ITK@9bf745b "PERF: Use FixedArray for BSplineInterpolationWeightFunction OutputType" (merged on 7 September 2021, included with ITK v5.3rc01). Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03" (merged on 18 February 2022).
Code like `WeightsType weights(n)` does not necessarily construct an object of `n` weights, as it did before ITK 5.3. It now fills a fixed array of weights by value `n`. This behavior change is caused by a change of the definition of `itk::BSplineInterpolationWeightFunction::WeightsType`, by ITK pull request InsightSoftwareConsortium/ITK#2712 commit InsightSoftwareConsortium/ITK@9bf745b "PERF: Use FixedArray for BSplineInterpolationWeightFunction OutputType" (merged on 7 September 2021, included with ITK v5.3rc01). Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03" (merged on 18 February 2022).
Upgraded ITK on the CI to version 5.3 RC04, which was tagged on 12 July 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc04 Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03", 18 February 2022.
Upgraded ITK on the CI to version 5.3 RC04, which was tagged on 12 July 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc04 Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03", 18 February 2022.
Upgraded ITK on the CI to version 5.3 RC04, which was tagged on 12 July 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc04 Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03", 18 February 2022.
Upgraded ITK on the CI to version 5.3 RC04, which was tagged on 12 July 2022 and released on 23 August 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc04 Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03", 18 February 2022.
Upgraded ITK on the CI to version 5.3 RC04, which was tagged on 12 July 2022 and released on 23 August 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc04 Follow-up to pull request #620 commit a0cf523 "COMP: Upgrade ITK from v5.2.0 to v5.3rc03", 18 February 2022.
Upgraded to ITK version 5.3 (RC03), which was tagged on 16 January 2022: https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3rc03
Including upgrade to C++14, and various performance improvements:
InsightSoftwareConsortium/ITK@6a8569e Use the faster
TransformPhysicalPointToContinuousIndex
overloadInsightSoftwareConsortium/ITK@eb6ac88 Use the faster
TransformPhysicalPointToIndex
overload in filterInsightSoftwareConsortium/ITK@0539a2c Remove protected
itk::Transform
data memberm_DirectionChange
InsightSoftwareConsortium/ITK@eec9fe6 Remove unnecessary
IdentityTransform::m_ZeroJacobian
InsightSoftwareConsortium/ITK@9961ccd Use FastEvaluate in MattesMutualInformationImageToImageMetric + v4
InsightSoftwareConsortium/ITK@9745409 Use FixedArray for table within BSplineInterpolationWeightFunction
InsightSoftwareConsortium/ITK@c23944b Remove BSplineInterpolationWeightFunction Kernel, use FastEvaluate
InsightSoftwareConsortium/ITK@bc7c5df Use FixedArray for BSplineBaseTransform ParameterIndexArrayType
InsightSoftwareConsortium/ITK@9bf745b Use FixedArray for BSplineInterpolationWeightFunction OutputType
InsightSoftwareConsortium/ITK@c64a58d Make
ResampleImageFilter::LinearThreadedGenerateData
fasterFollow-up to pull request #475 commit 6803b26 "COMP: Upgrade ITK from v5.1.1 to v5.2.0" (merged on 31 May 2021).
Note: The last elastix git revision on the develop branch that still supported ITK 5.2 was tagged: "last-itk5.2-support"