Add support for TLS responses in v2.2.0 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for this PR. Looks like our git flow got messed up somewhere when several PR's were merged onto the |
peschuster
force-pushed
the
feature-casparv22-tls
branch
from
a095e33 to
db03fda
Compare
|
No problem. I just rebased both PRs. |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature / support for CasparCG v2.2
What is the current behavior? (You can also link to an open issue here)
Response from CasparCG server v2.2 of TLS command is not recognized (see issue null response from tls command #112).
What is the new behavior (if this is a feature change)?
Plain lists without any additional fields are assumed to be responses from CasparCG v2.2 with just the name of the template.
Other information
Tested with official CasparCG release "2018-12-29 - Version 2.2.0 Stable" and used in production at two multi day events during the last months with CasparCG as video playout server and generator for lower thirds.