【feature】高亮结果弹窗样式参数调整; review by qiw

SuperMap · Oct 30, 2024 · a05e928 · a05e928
1 parent 498a0df
commit a05e928
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 39 deletions.
diff --git a/src/common/attribute-panel/AttributePanel.vue b/src/common/attribute-panel/AttributePanel.vue
@@ -80,7 +80,7 @@ class SmAttributePanel extends Mixins(Theme) {
       columns: this.columns,
       showHeader: this.showHeader,
       background: 'transparent',
-      textColor: 'inherit'
+      textColor: this.textColor
     };
   }
 

diff --git a/src/mapboxgl/layer-highlight/LayerHighlight.vue b/src/mapboxgl/layer-highlight/LayerHighlight.vue
@@ -94,33 +94,34 @@ export default {
       return this.allPopupDatas[this.currentIndex] || [];
     },
     columnStyle() {
-      const { autoResize, keyWidth, valueWidth, keyMaxWidth, valueMaxWidth, keyWordStyle, valueWordStyle} = this.popupStyle;
-      let style = { keyStyle: {}, valueStyle: {} };
+      const { autoResize, keyWidth, valueWidth, keyMaxWidth, valueMaxWidth, keyWordStyle, valueWordStyle } = this.popupStyle;
+      const style = { keyStyle: {}, valueStyle: {} };
+      if (keyWidth) {
+        style.keyStyle.minWidth = keyWidth + 'px';
+      }
+      if (valueWidth) {
+        style.valueStyle.minWidth = valueWidth + 'px';
+      }
+      if (keyMaxWidth) {
+        style.keyStyle.maxWidth = keyMaxWidth + 'px';
+      }
+      if (valueMaxWidth) {
+        style.valueStyle.maxWidth = valueMaxWidth + 'px';
+      }
       if (!autoResize) {
-        if (keyWidth) {
-          style.keyStyle.width = keyWidth + 'px';
-        }
-        if (valueWidth) {
-          style.valueStyle.width = valueWidth + 'px';
-        }
-      } else {
-        if (keyMaxWidth) {
-          style.keyStyle.maxWidth = keyMaxWidth + 'px';
-        }
-        if (valueMaxWidth) {
-          style.valueStyle.maxWidth = valueMaxWidth + 'px';
-        }
+        style.keyStyle.maxWidth = style.keyStyle.minWidth;
+        style.valueStyle.maxWidth = style.valueStyle.minWidth;
       }
       const ellipsisStyle = {
         overflow: 'hidden',
         textOverflow: 'ellipsis',
         whiteSpace: 'nowrap'
+      };
+      if (keyWordStyle === 'ellipsis') {
+        style.keyStyle = { ...style.keyStyle, ...ellipsisStyle };
       }
-      if (keyWordStyle === 'ellipsis'){
-        style.keyStyle = {...style.keyStyle, ...ellipsisStyle}
-      }
-      if (valueWordStyle === 'ellipsis'){
-        style.valueStyle = {...style.valueStyle, ...ellipsisStyle}
+      if (valueWordStyle === 'ellipsis') {
+        style.valueStyle = { ...style.valueStyle, ...ellipsisStyle };
       }
       return style;
     },

diff --git a/src/mapboxgl/layer-highlight/__tests__/LayersHighlight.spec.js b/src/mapboxgl/layer-highlight/__tests__/LayersHighlight.spec.js
@@ -71,8 +71,8 @@ describe('LayerHighlight.vue', () => {
     expect(wrapper.find(SmMapPopup).exists()).toBe(true);
     expect(wrapper.vm.tableColumns.length).toBe(2);
     const style = { overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' };
-    expect(wrapper.vm.columnStyle.keyStyle).toEqual({ ...style, maxWidth: '160px' });
-    expect(wrapper.vm.columnStyle.valueStyle).toEqual({ ...style, maxWidth: '300px' });
+    expect(wrapper.vm.columnStyle.keyStyle).toEqual({ ...style, maxWidth: '160px', minWidth: '80px' });
+    expect(wrapper.vm.columnStyle.valueStyle).toEqual({ ...style, maxWidth: '300px', minWidth: '150px' });
     done();
   });
 
@@ -139,21 +139,6 @@ describe('LayerHighlight.vue', () => {
     done();
   });
 
-  it('set featureFieldsMap', done => {
-    wrapper = mount(SmLayerHighlight, {
-      propsData: {
-        mapTarget: 'map',
-        uniqueName: 'Test',
-        highlightStyle: {}
-      }
-    });
-    const setSpy = jest.spyOn(wrapper.vm.viewModel, 'setDisplayFieldsMap');
-    wrapper.setProps({ displayFieldsMap: {} });
-    wrapper.vm.$nextTick();
-    expect(setSpy).toBeCalled();
-    done();
-  });
-
   it('set clickTolerance', done => {
     wrapper = mount(SmLayerHighlight, {
       propsData: {

diff --git a/src/mapboxgl/map-popup/MapPopup.vue b/src/mapboxgl/map-popup/MapPopup.vue
@@ -9,6 +9,7 @@
       :textColor="textColor"
       :attributes="data[defaultIndex]"
       :columns="columns"
+      :showHeader="showHeader"
       @change="changeIndex"
     >
     </sm-attribute-panel>

diff --git a/src/mapboxgl/query/Query.vue b/src/mapboxgl/query/Query.vue
@@ -142,7 +142,7 @@
       :clickTolerance="clickTolerance"
       :popupStyle="popupStyle"
       :background="popupStyle.background || background"
-      :textColor="popupStyle.background || textColor"
+      :textColor="popupStyle.textColor || textColor"
       :mapTarget="mapTarget"
       :customColumnRenders="$scopedSlots"
       :showPopup="showPopup"