Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : delete magazine useMemo (banner) #199

Merged
merged 3 commits into from
Sep 16, 2023
Merged

fix : delete magazine useMemo (banner) #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea61d8d
fix: 최종 QA 리스트업 수정 (#196)
blan19 Jun 11, 2023
2811d75
Bug fix.magazine banner fix (#198)
doyupK Sep 16, 2023
18980e6
Merge branch 'main' into develop
doyupK Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions apps/web/src/components/magazine/magazineList/magazineList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,24 @@ const MagazineList = () => {
const { data: magazine } = useMagazine({ page, keyword });
const { push } = useRouter();
const isMagazine = magazine && magazine.data.length > 0;
const newMagainze = React.useMemo(() => {
if (isMagazine) return magazine.data[0];
return null;
}, []);
// const newMagainze = React.useMemo(() => {
// if (isMagazine) return magazine.data[0];
// return null;
// }, []);

return (
<Container display="flex" flexDirection="column" alignItems="center">
{isMagazine ? (
<>
{newMagainze && (
<Link
href={`/magazine/${magazine.data[0].id}`}
style={{
cursor: 'pointer',
}}
>
<MagazineBanner initialData={newMagainze} />
</Link>
)}
<Link
href={`/magazine/${magazine.data[0].id}`}
style={{
cursor: 'pointer',
}}
>
<MagazineBanner initialData={magazine.data[0]} />
</Link>

<Wrapper
css={css`
width: 880px;
Expand Down
Loading