Handle missing credentials as being invalid (#1164)

In case the credentials were missing the basic authentication was just bypassed
Suwayomi · Nov 23, 2024 · 38673bb · 38673bb
1 parent fb51834
commit 38673bb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/src/main/kotlin/suwayomi/tachidesk/server/JavalinSetup.kt b/server/src/main/kotlin/suwayomi/tachidesk/server/JavalinSetup.kt
@@ -108,7 +108,7 @@ object JavalinSetup {
 
         app.beforeMatched { ctx ->
             fun credentialsValid(): Boolean {
-                val basicAuthCredentials = ctx.basicAuthCredentials() ?: return true
+                val basicAuthCredentials = ctx.basicAuthCredentials() ?: return false
                 val (username, password) = basicAuthCredentials
                 return username == serverConfig.basicAuthUsername.value &&
                     password == serverConfig.basicAuthPassword.value