Feature/use graphql #395
Merged
Feature/use graphql #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"bundler" causes a tsc issue with the generated graphql file where the imported file can't be found.
Makes it possible to modify the generated graphql file by codegen.
Even if they are generated files, they should be checked-in so that it's possible to check out an old commit and still have the same files as they were at the time the commit was created. In case they wouldn't be checked-in and the schema has changed in the meantime, there is no possible way to build the same generated files anymore
The "loading" and "networkStatus" state do not get correctly updated when e.g. calling "fetchMore". This seems to happen because an abort signal is passed on every hook call. Due to passing this signal, the passed args to the hook change, and thus, it looks like apollo considers this a completely new hook call. By preventing the signal from being passed, the hook correctly updates these states, but, on the contrary, it is not possible to abort these requests anymore
Was only updated after clicking "OK" once. This was caused due only updating the language selection once the app language was changed or in case the selected languages (after clicking "OK") changed
Due to setting categories to be an empty array by default, the loading text was never shown
the gql updater subscription currently return stale data, thus, the mangas do net get updated in the cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.