Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas estimation #1726
base: develop
Are you sure you want to change the base?
Gas estimation #1726
Changes from 14 commits
2ad37cf
82bee3a
5ddda0d
f951bbd
1dd1c8b
9f2a9f2
893a895
af8c838
4fa4eb2
c0d1437
3fc3a35
0604e9b
75cfdd6
c010814
7433d56
a4c7843
3533466
d5517ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
transactionRequest
is undefined it could break when checkingtransactionRequest.gasLimit
. Also I don't think we want toconsole.log
the error, use.error
in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this part I noticed during testing that it wasn't handling the error so I put this in place. It didn't throw it for me.