New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(macOS only) Dependencies are not injected if a view/window is instantiated with `instantiateInitialController` #166

Open

yoichitgy opened this issue Aug 20, 2021 · 0 comments

Labels

bug

Member

yoichitgy commented Aug 20, 2021 •

edited

Loading

As discussed in PR #157, dependencies are not injected if used with instantiateInitialController on macOS. This issue does not appear on iOS/tvOS.

It looks the cause relates to the new NSStoryboard APIs Apple introduced for macOS 10.15+ and Xcode 11.0+

The old and still available API is instantiateInitialController() https://developer.apple.com/documentation/appkit/nsstoryboard/1426545-instantiateinitialcontroller
The new API to instantiate NSViewController is instantiateInitialController(creator:) https://developer.apple.com/documentation/appkit/nsstoryboard/3203779-instantiateinitialcontroller
The new API to instantiate NSWindowController is instantiateInitialController(creator:) https://developer.apple.com/documentation/appkit/nsstoryboard/3203780-instantiateinitialcontroller

Some unit tests in macOS target show the issue, and currently the tests do not pass.

The text was updated successfully, but these errors were encountered:

yoichitgy added the bug label

yoichitgy mentioned this issue

Remove dependency on Quick/Nimble #157

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment