Remove dependency on Quick/Nimble #157
Conversation
| // We need to have test bundle deployment target on iOS 9.0 in order to compile storyboards with references. | ||
| // However, we need to disable these tests when running on iOS <9.0 | ||
| // Using #available(iOS 9.0, *) produces compiler warning for the reasons above | ||
| if ProcessInfo().isOperatingSystemAtLeast(OperatingSystemVersion(majorVersion: 9, minorVersion: 0, patchVersion: 0)) { |
There was a problem hiding this comment.
We can remove the iOS version check because we no longer support iOS 8.
There was a problem hiding this comment.
Although the current iOS deployment target is set to 12.0, it looks the target was increased by accident in the following PR. It looks good to revert the target to 9.0 later.
#156 (review)
|
Do the failing tests also fail for |
|
The failing tests also fail for The tests fail with |
|
Gotcha. Are you cool with merging this PR after I do the release? Or do you think it's safe enough to go into the release? |
|
I don't mind merging this PR after you make the release👍 Meanwhile, I'll check the cause of the test failure more😉 So far, I tried updating the dependency on Swinject to the latest commit, but the tests still failed... |
|
I noticed unit tests failed if a vew/window controller was instantiated with |
|
From what I remember we employed some hacks to get that to work. Perhaps newer versions of the iOS SDK broke those hacks. |
|
It looks the cause relates to the new NSStoryboard APIs Apple introduced for macOS 10.15+ and Xcode 11.0+
I'm still investigating the issue. |
|
I made the investigation, but still not sure why |
|
@yoichitgy release has been completed! Feel free to merge when you're ready! |
# Conflicts: # SwinjectStoryboard.xcodeproj/project.pbxproj
This PR addresses the same issue of Swinject Issue #472, and performs the migration from Quick/Nimble to XCTest in the same way as Swinject PR #473.
XxxSpecusing Quick/Nimble withXxxTestsusing XCTest.Note
Unit tests corresponding to those failed with Quick/Nimble still fail for macOS target. We need investigation later.